Class ArmorCluedo

maybe the issues with aRMOR are due to a lack in its documentation. The implemented workarounds could reduce the performances of the program.

Class ArmorTools

actually the class has some methods missing, for example methods for modifying client name and reference name.

sequential commands to aRMOR is not supported right now: only the single command service is used.

the interface actually can load the ontology only from file. It could be a good idea to have tools also for loading it from another source.

Global ArmorTools::CallArmor (armor_msgs::ArmorDirective &data)

there's no way to compose aRMOR commands in a list. actually ARMOR_SERVICE_MULTIPLE_REQUESTS is unused.

Global ChooseRoomRandom (robocluedo_msgs::RandomRoom::Request &empty, robocluedo_msgs::RandomRoom::Response &room)

should the node choose a room which is not also the actual position?

File cluedo_movement_controller.cpp

this is a STUB implementation. It should be replaced with a real movement controller.

File cluedo_oracle.cpp

expose the value MAX_SIZE_HINT o the parameter server as done with MAX_NUM_HINTS.

Global generateMystery (std::vector< std::string > list_who, std::vector< std::string > list_where, std::vector< std::string > list_what, int tot_hints)

could this algorithm be further improved?

let the user to modify this value instead of putting a constant.

there should be parameters for altering the probabilities in generating the hints belonging to an ID

Global robocluedo_main.charge

the buffer should be a list of hints instead of a single value

Global robocluedo_main.listen_for_hints (data)

the singlevar buffer should become a list buffer

Class robocluedo_main.robocluedo_update_ontology

exporting the ontology at each update could be too much expensive in terms of performances. There should be a setting (using parameter server) which lets the user to select when to make a backup of the ontology on file.

File test_armor_tools.cpp

translate logs from italian to English and reorder